Incidentally, you mention that there were some known problems. Are you aware of anything else that hasn’t been touched on in these comments?

Definitely three cheers for open source!

David

Many thanks. I know the feeling all too well of not getting the last 5% done !

I had thought about this before but didn’t give it much attention. The $dayToUse = date(‘w’) + 1 (when == 0 ) isn’t right. You’re using 1-7 for Monday through Sunday, so that would theoretically duplicate Monday’s schedule twice.

Although, and I’m far too tired right now to delve into it, that’s not what happened. Instead, I noticed that after midnight on Saturday (thus, on Sunday) tweets began sending at the cron-job interval (in my case, 5 minutes) rather than at any interval listed in the ’schedules’ table (all greater than 10 minutes).

I’ve changed:

=====
if (date(‘w’) == 0) {
$dayToUse = date(‘w’) + 1;
} else {
$dayToUse = date(‘w’);
}
=====

to:

=====
if (date(‘w’) == 0) {
$dayToUse= ‘7′;
} else {
$dayToUse = date(‘w’);
}

=====

And now I’m going to get some much-needed sleep.

Best,

David

What you’re doing is great.

Scheduled Tweets is 95% complete but had that 5% problems which was causing problems. I did some updates locally but couldn’t find time complete & organize them.

It’ll be great that you post any updates you make, I’ll be watching them and once you’re ok, I’ll update the download.

Again, thanks so much, this is why I love open source .

1) As James West points out, add “$status = urlencode($status);” near the beginning of the if statements (such as under the “$tweetUrl = …” statement.

2) The script does exactly what it’s supposed to. Unless you are encountering a technical issue (i.e. connection issue with mySQL database), you may be expecting something different of it. For example, tweets go out at the interval scheduled, during the days and times entered (don’t miss this step), and when Scheduled Tweets is “started” but not when it is “stopped”. Each tweet you enter will only ever get tweeted once (tweetStatus flag), so if you enter three tweets and have an interval of 5 minutes–and you don’t enter more tweets–cron will continue running the job but you won’t see anything new after about 15 minutes. As written, it doesn’t loop and the same tweets aren’t then tweeted the next day.

3) FYI, I’m not the David or Dave who posted _prior_ to today.

Best,

David

Number 3 should read…

3) In the section [-= if ($action == "newTweet"){ =-] just before [-= $query = "INSERT INTO tweets... =-] I added:

David

Thanks also to Steve for bug-fix suggestions.

I modified functions.php in a couple of ways that others might find helpful (and probably won’t stop there)…

***

1: My error_log was filling up faster than I could keep track of it because of the lack of parameters usualy being sent and the interval of the cron job. I added this function and changed the variable assignment accordingly. Note that I commented out the use of the myfilter class, figuring that if I’m the only one adding the tweets that I could know to be careful about using tags and such.

function setVar ($varName) {

if (!empty($_POST[$varName])) {
$checkValue = $_POST[$varName];
} else {
if (!empty($_GET[$varName])) $checkValue = $_GET[$varName];
else $checkValue = ”;
}

return $checkValue;

}

$installDBName = setVar(‘installDBName’);
$installDBUser = setVar(‘installDBUser’);
$installDBPass = setVar(‘installDBPass’);
$installDBHost = setVar(‘installDBHost’);
etc., etc. [make sure to catch them all--there's one GET and the rest are POST]

***

2) I also quoted the ‘w’ in this section of code (in 3 places) to eliminate those error_log entries:

if (date(‘w’) == 0) {
$dayToUse = date(‘w’) + 1;
} else {
$dayToUse = date(‘w’);
}

***

3) In the >> if ($action == “newTweet”){ <> $query = “INSERT INTO tweets… <<, I added:

$tweetDetails = str_replace(chr(10),'',$tweetDetails);
$tweetDetails = str_replace(chr(13),'',$tweetDetails);
$tweetDetails = mysql_real_escape_string($tweetDetails);

This removes carriage returns and newlines that might inadvertently get put into the tweet, and also properly escapes various characters appropriate for insertion in mySQL such as quotation marks, apostrophes and backslashes (see php.net/mysqlreal_escape_string)

***

4) A minor change but worth considering:

The text "Error, insert query failed" appears in six places in the code and "Error, update query failed" appears in three. I numbered them so I'd be able to tell where a problem was occuring (i.e. failed #1..#6,failed #1..#3).

***

Hope this proves to be helpful for others.

David

The cron address must be: http://www.yourdomainname.com/inc/functions.php?getAction=cronTweet

Thanks!

In your RSS reader, check the latest WRD post:
You’ll find “special downloads” at the bottom of the post.